feat: media files tab - Part 2 (WPB-5378) #2523

alexandreferris · 2023-12-13T16:36:58Z

WPB-5378 Files tab in media gallery

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

… proper color of text

…message module

# Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/media/ConversationMediaScreen.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/media/EmptyMediaContentScreen.kt # kalium

# Conflicts: # kalium

github-actions · 2023-12-13T16:37:28Z

@alexandreferris looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (feat/media_files_tab_epic) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

feat/media_files_tab_epic	This PR
d37b5cba05f4c77cbf556a3b6ad1261efc9e0562	e3382753be0c1203ddb60e4253a0229efb8efc50

Is this intentional?

github-actions · 2023-12-13T16:40:56Z

Test Results

733 tests 733 ✔️ 7m 35s ⏱️
101 suites     0 💤
101 files     0 ❌

Results for commit 50d5938.

♻️ This comment has been updated with latest results.

AndroidBob · 2023-12-13T16:49:25Z

Build 2290 failed.

github-actions · 2023-12-13T16:55:20Z

@alexandreferris looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (feat/media_files_tab_epic) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

feat/media_files_tab_epic	This PR
d37b5cba05f4c77cbf556a3b6ad1261efc9e0562	e3382753be0c1203ddb60e4253a0229efb8efc50

Is this intentional?

AndroidBob · 2023-12-13T17:07:07Z

Build 2291 failed.

github-actions · 2023-12-14T12:42:12Z

@alexandreferris looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (feat/media_files_tab_epic) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

feat/media_files_tab_epic	This PR
d37b5cba05f4c77cbf556a3b6ad1261efc9e0562	e3382753be0c1203ddb60e4253a0229efb8efc50

Is this intentional?

github-actions · 2023-12-14T13:10:00Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-12-14T13:28:59Z

Build 2297 succeeded.

The build produced the following APK's:

com.wire.android-v4.6.0(8359117)(8359117)-staging-compat.apk

AndroidBob · 2023-12-19T16:40:40Z

Build 2378 failed.

AndroidBob · 2023-12-20T09:55:39Z

Build 2388 failed.

github-actions · 2023-12-20T10:38:21Z

APKs built during tests are available here. Scroll down to Artifacts!

# Conflicts: # kalium

github-actions · 2023-12-20T11:10:28Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-12-20T11:34:30Z

Build 2393 succeeded.

The build produced the following APK's:

com.wire.android-v4.6.0(8410284)(8410284)-staging-compat.apk

alexandreferris added 15 commits December 8, 2023 11:01

feat: add strings for empty state

9ebb87e

feat: add empty state screen for media

190171e

feat: add empty state screens for media

4dd91a5

feat: center text in vertical and horizontal center of screen and add…

627f6dd

… proper color of text

Merge branch 'develop' into feat/media_files_tab_part2

b4548d7

chore: update kalium reference to in development for media files

5c25f17

feat: add new use case to get only image assets from conversation to …

e615df8

…message module

feat: move group by month and year to extensions file

b4b4679

feat: add new usecase to get asset messages and combine with user info

f5cb759

feat: add initial display of asset messages

2d27227

Merge branch 'feat/media_files_tab_epic' into feat/media_files_tab_part2

95a8430

# Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/media/ConversationMediaScreen.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/media/EmptyMediaContentScreen.kt # kalium

chore: fix merge conflicts

42ad6b8

chore: update to kalium reference for development

dc759aa

Merge branch 'develop' into feat/media_files_tab_part2

9e7028e

# Conflicts: # kalium

chore: adjust naming of extension functions

244fab3

alexandreferris self-assigned this Dec 13, 2023

pull-request-size bot added the size/XL label Dec 13, 2023

alexandreferris added WIP Work In Progress DO NOT MERGE labels Dec 13, 2023

chore: detekt

ac64870

chore: adjust detekt

4e3af11

chore: tentative of pagination for media files result

1a5f74d

chore: get latest changes from kalium branch

1477654

feat: date time label in media files

04965ea

alexandreferris added 3 commits December 20, 2023 11:06

chore: adjust function naming on message module

5710d64

chore: remove blank line

9a5c60b

chore: detekt max line length

7b6d735

Merge branch 'develop' into feat/media_files_tab_part2

384b98a

# Conflicts: # kalium

pull-request-size bot added size/XXL and removed size/L labels Dec 20, 2023

Merge branch 'feat/media_files_tab_epic' into feat/media_files_tab_part2

effe696

pull-request-size bot added size/L and removed size/XXL labels Dec 20, 2023

chore: update kalium with latest changes from feature branch

50d5938

alexandreferris requested review from a team, typfel, yamilmedina, borichellow, MohamadJaara and Garzas and removed request for a team December 20, 2023 14:31

alexandreferris assigned Garzas Dec 20, 2023

Garzas approved these changes Dec 21, 2023

View reviewed changes

saleniuk approved these changes Dec 22, 2023

View reviewed changes

Garzas merged commit 45f95ce into feat/media_files_tab_epic Dec 22, 2023
15 checks passed

Garzas deleted the feat/media_files_tab_part2 branch December 22, 2023 08:55

echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: media files tab - Part 2 (WPB-5378) #2523

feat: media files tab - Part 2 (WPB-5378) #2523

alexandreferris commented Dec 13, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Dec 13, 2023

github-actions bot commented Dec 13, 2023 •

edited

Loading

AndroidBob commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

AndroidBob commented Dec 13, 2023

github-actions bot commented Dec 14, 2023

github-actions bot commented Dec 14, 2023

AndroidBob commented Dec 14, 2023

AndroidBob commented Dec 19, 2023

AndroidBob commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

AndroidBob commented Dec 20, 2023

feat: media files tab - Part 2 (WPB-5378) #2523

feat: media files tab - Part 2 (WPB-5378) #2523

Conversation

alexandreferris commented Dec 13, 2023 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Causes (Optional)

Solutions

Dependencies (Optional)

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented Dec 13, 2023

github-actions bot commented Dec 13, 2023 • edited Loading

Test Results

AndroidBob commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

AndroidBob commented Dec 13, 2023

github-actions bot commented Dec 14, 2023

github-actions bot commented Dec 14, 2023

AndroidBob commented Dec 14, 2023

AndroidBob commented Dec 19, 2023

AndroidBob commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

AndroidBob commented Dec 20, 2023

alexandreferris commented Dec 13, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Dec 13, 2023 •

edited

Loading